Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ecobee service schemas #26955

Merged

Conversation

@marthoc
Copy link
Contributor

commented Sep 27, 2019

Description:

Validates date and time values as being appropriately formatted for the ecobee API.

Adds a restriction on vacation_name (max length of 12 characters was revealed in testing, but is not disclosed in ecobee API documentations).

Related issue (if applicable): fixes #26953
Pull request with documentation for home-assistant.io (if applicable): N/A

Example entry for configuration.yaml (if applicable):

N/A

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
marthoc added 2 commits Sep 27, 2019
Improve validation with utility functions.
@project-bot project-bot bot added this to Needs review in Dev Sep 27, 2019
@marthoc

This comment has been minimized.

Copy link
Contributor Author

commented Sep 27, 2019

@MartinHjelmare as discussed in #26923!

Copy link
Member

left a comment

Looks great!

Dev automation moved this from Needs review to Reviewer approved Sep 27, 2019
@marthoc

This comment has been minimized.

Copy link
Contributor Author

commented Sep 27, 2019

Added tests for the ecobee.util functions to improve code coverage.

@marthoc

This comment has been minimized.

Copy link
Contributor Author

commented Sep 27, 2019

Good to go!

@marthoc marthoc requested a review from MartinHjelmare Sep 27, 2019
tests/components/ecobee/test_util.py Outdated Show resolved Hide resolved
Dev automation moved this from Reviewer approved to Review in progress Sep 27, 2019
Copy link
Member

left a comment

Good!

Dev automation moved this from Review in progress to Reviewer approved Sep 27, 2019
@MartinHjelmare MartinHjelmare merged commit 2dfdc5f into home-assistant:dev Sep 28, 2019
9 checks passed
9 checks passed
CI Build #20190927.61 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
Dev automation moved this from Reviewer approved to Done Sep 28, 2019
@lock lock bot locked and limited conversation to collaborators Sep 29, 2019
@marthoc marthoc deleted the marthoc:improve-ecobee-service-schemas branch Oct 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.