Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible OpenUV exception due to missing data #26958

Merged
merged 1 commit into from Sep 28, 2019

Conversation

@bachya
Copy link
Contributor

commented Sep 27, 2019

Description:

Very rarely, OpenUV can fail to return fields when requesting data, which can cause an unhandled device update exception. This PR addresses that possibility.

Related issue (if applicable): fixes ##26946

Pull request with documentation for home-assistant.io (if applicable): N/A

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
@bachya bachya self-assigned this Sep 27, 2019
@project-bot project-bot bot added this to Needs review in Dev Sep 27, 2019
Dev automation moved this from Needs review to Reviewer approved Sep 28, 2019
@balloob balloob merged commit ce97c27 into home-assistant:dev Sep 28, 2019
12 checks passed
12 checks passed
CI Build #20190927.47 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected.
Details
codecov/project 94.19% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Sep 28, 2019
@lock lock bot locked and limited conversation to collaborators Sep 29, 2019
@bachya bachya deleted the bachya:fix-26946 branch Oct 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.