Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove no longer needed Python < 3.6 compatibility code #27024

Merged
merged 1 commit into from Sep 28, 2019

Conversation

@scop
Copy link
Contributor

commented Sep 27, 2019

Description:

Seems async_.run_coroutine_threadsafe could be replaced with asyncio.run_coroutine_threadsafe altogether otherwise, except that the latter does not raise a RuntimeError when run in the event loop, and the test suite tests for that behavior.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
@scop scop requested a review from home-assistant/core as a code owner Sep 27, 2019
@project-bot project-bot bot added this to Needs review in Dev Sep 27, 2019
Copy link
Member

left a comment

Nice!

Dev automation moved this from Needs review to Reviewer approved Sep 27, 2019
@balloob balloob merged commit ac634d7 into home-assistant:dev Sep 28, 2019
10 checks passed
10 checks passed
CI Build #20190927.63 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Sep 28, 2019
@scop scop deleted the scop:remove-obsolete-code branch Sep 28, 2019
@lock lock bot locked and limited conversation to collaborators Sep 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.