Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve validation of device action config #27029

Merged

Conversation

@emontnemery
Copy link
Contributor

commented Sep 28, 2019

Description:

Improve validation of device action config.
This includes action part from #26830

Improve both when loading at startup, and when an automation is modified through the automation editor UI.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@emontnemery emontnemery requested a review from home-assistant/core as a code owner Sep 28, 2019
@project-bot project-bot bot added this to Needs review in Dev Sep 28, 2019
"""Validate config."""
action_type = _determine_action(config)

if action_type == ACTION_DEVICE_AUTOMATION:

This comment has been minimized.

Copy link
@balloob

balloob Oct 1, 2019

Member

Should we validate the other types?

This comment has been minimized.

Copy link
@emontnemery

emontnemery Oct 1, 2019

Author Contributor

Not sure it's needed, other types are still validated through the action schema. We need to validate ACTION_CONDITION because it might include device conditions. That's coming in a follow up PR.

@balloob
balloob approved these changes Oct 1, 2019
Copy link
Member

left a comment

Ok when comment answered

Dev automation moved this from Needs review to Reviewer approved Oct 1, 2019
@balloob balloob merged commit 5a1da72 into home-assistant:dev Oct 2, 2019
12 checks passed
12 checks passed
CI Build #20190928.6 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.24%)
Details
codecov/project 94.24% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Oct 2, 2019
@lock lock bot locked and limited conversation to collaborators Oct 3, 2019
@emontnemery emontnemery deleted the emontnemery:device_action_config_validation branch Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.