Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return esphome cover position as Integer #27039

Merged
merged 1 commit into from Sep 29, 2019

Conversation

@neffs
Copy link
Contributor

commented Sep 28, 2019

Description:

Cover position is specified as Integer 0-100, we should not return float here.

Related issue (if applicable): fixes #25738

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
@neffs neffs requested a review from OttoWinter as a code owner Sep 28, 2019
@project-bot project-bot bot added this to Needs review in Dev Sep 28, 2019
Dev automation moved this from Needs review to Review in progress Sep 29, 2019
cover position is specified as integer 0-100, we should not return
float here.
fixes #25738
@neffs neffs force-pushed the neffs:fix-esphome-homekit branch from 2cbc837 to cf20663 Sep 29, 2019
Copy link
Member

left a comment

Thanks!

Dev automation moved this from Review in progress to Reviewer approved Sep 29, 2019
@MartinHjelmare MartinHjelmare changed the title Return esphome cover position as Integer, fixes Homekit Return esphome cover position as Integer Sep 29, 2019
@MartinHjelmare MartinHjelmare merged commit 4f55235 into home-assistant:dev Sep 29, 2019
11 checks passed
11 checks passed
CI Build #20190929.9 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing f464a78...cf20663
Details
codecov/project 94.3% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Sep 29, 2019
@lock lock bot locked and limited conversation to collaborators Sep 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.