Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scale and offset to temperature values to Modbus Climate #27045

Merged
merged 4 commits into from Nov 26, 2019

Conversation

@adamchengtkc
Copy link
Contributor

adamchengtkc commented Sep 29, 2019

Breaking Change:

No breaking change

Description:

  1. Change HVAC mode to HVAC_MODE_AUTO since the logic for most ventilation/AC are managed by the unit itself
  2. Added optional scale and offset in similar fashion to Modbus sensor
  3. Added optionally configurable min_temp, max_temp and temp_step to avoid values not supported by the HVAC
  4. Added optionally configurable temperature unit

This is my first PR and I have tried to read as many doc as possible. Please correct me if I done something wrong.

Related issue (if applicable): fixes #17873

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10480

Example entry for configuration.yaml (if applicable):

  - platform: modbus
    name: Ventilation
    hub: default
    slave: 1
    data_type: uint
    target_temp_register: 135
    current_temp_register: 8
    data_count: 1
    scale: 0.1
    precision: 1
    max_temp: 30
    min_temp: 15
    temp_step: 1

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@project-bot project-bot bot added this to Needs review in Dev Sep 29, 2019
@adamchengtkc adamchengtkc changed the title Add scale and offset to temperature values Add scale and offset to temperature values to Modbus Climate Sep 29, 2019
@frenck

This comment has been minimized.

Copy link
Member

frenck commented Sep 30, 2019

Thank you for your contribution thus far! 🎖 Since this is a significant contribution, we would appreciate you'd added yourself to the list of code owners for this integration. ❤️

Please, add your GitHub username to the manifest.json of this integration.

For more information about "code owners", see: Architecture Decision Record 0008: Code owners.

adamchengtkc added 2 commits Oct 1, 2019
@skabelkins

This comment has been minimized.

Copy link

skabelkins commented Oct 26, 2019

Looking forward to this feature.

@kontaktanderson

This comment has been minimized.

Copy link

kontaktanderson commented Oct 29, 2019

Also looking forward to this feature, especially because the current component is broken due to missing temperature unit :-)

@adamchengtkc

This comment has been minimized.

Copy link
Contributor Author

adamchengtkc commented Oct 29, 2019

@frenck What does it take to get it merged? Thanks
@skabelkins @kontaktanderson It would be helpful if you can help testing this by downloading all the folder under https://github.com/adamchengtkc/home-assistant/tree/test/homeassistant/components/modbus and put them in a modbus folder under custom_components

@kontaktanderson

This comment has been minimized.

Copy link

kontaktanderson commented Oct 29, 2019

@adamchengtkc tested and found fully functional :-)

@skabelkins

This comment has been minimized.

Copy link

skabelkins commented Nov 16, 2019

@balloob sorry for disturbing,
Modbus Climate component is broken more than a year (see #17873); this MR fixes it, but nobody cares. Could you please invite someone who is in charge of reviewing this? Thanks in advance.

Dev automation moved this from Needs review to Reviewer approved Nov 26, 2019
@balloob balloob merged commit 6e7b5b7 into home-assistant:dev Nov 26, 2019
11 checks passed
11 checks passed
CI Build #20191001.55 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing f464a78...bd62b89
Details
codecov/project 94.31% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Nov 26, 2019
@lock lock bot locked and limited conversation to collaborators Nov 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
6 participants
You can’t perform that action at this time.