Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dark sky time in forecasts #27049

Merged
merged 1 commit into from Sep 30, 2019

Conversation

@MatthewFlamm
Copy link
Contributor

commented Sep 29, 2019

Description:

Dark sky time for forecasts is currently received as a UTC time stamp. The current use of datetime.fromtimestamp causes time zone issues. Use of util function UTC from timestamp fixes this behavior.

Related issue (if applicable): fixes #26909 and #23166.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
@MatthewFlamm MatthewFlamm requested a review from fabaff as a code owner Sep 29, 2019
@project-bot project-bot bot added this to Needs review in Dev Sep 29, 2019
Copy link
Member

left a comment

Looks good!

@fabaff?

Dev automation moved this from Needs review to Reviewer approved Sep 29, 2019
@MatthewFlamm MatthewFlamm force-pushed the MatthewFlamm:darksky_tz_fix branch from 6e21b6c to e0b9577 Sep 29, 2019
@MatthewFlamm

This comment has been minimized.

Copy link
Contributor Author

commented Sep 29, 2019

rebased on dev to see if unrelated test failure will pass

@fabaff
fabaff approved these changes Sep 30, 2019
@fabaff fabaff merged commit 43bd116 into home-assistant:dev Sep 30, 2019
9 checks passed
9 checks passed
CI Build #20190929.39 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
Dev automation moved this from Reviewer approved to Done Sep 30, 2019
@lock lock bot locked and limited conversation to collaborators Oct 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.