Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Pi-hole enable and disable services #27055

Merged
merged 6 commits into from Sep 30, 2019

Conversation

@johnluetke
Copy link
Contributor

commented Sep 29, 2019

Description:

Introduces pi_hole.disable service to disable a Pi-hole for a specified amount of time, and pi_hole.enable service to enable a disabled Pi-hole

Pull request with documentation for home-assistant.io: home-assistant/home-assistant.io#10485

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
johnluetke added 2 commits Sep 15, 2019
@johnluetke johnluetke requested review from fabaff and home-assistant/core as code owners Sep 29, 2019
@project-bot project-bot bot added this to Needs review in Dev Sep 29, 2019
@johnluetke johnluetke referenced this pull request Sep 29, 2019
2 of 2 tasks complete
Dev automation moved this from Needs review to Review in progress Sep 29, 2019
homeassistant/components/pi_hole/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/pi_hole/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/pi_hole/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/pi_hole/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/pi_hole/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/pi_hole/__init__.py Outdated Show resolved Hide resolved
homeassistant/helpers/config_validation.py Outdated Show resolved Hide resolved
johnluetke added 2 commits Sep 29, 2019
Copy link
Member

left a comment

Good!

Dev automation moved this from Review in progress to Reviewer approved Sep 29, 2019
@MartinHjelmare MartinHjelmare removed the request for review from home-assistant/core Sep 29, 2019
@MartinHjelmare MartinHjelmare removed the core label Sep 29, 2019
@MartinHjelmare MartinHjelmare changed the title Pi-hole enable and disable services Add Pi-hole enable and disable services Sep 29, 2019
@cgarwood cgarwood merged commit 245e51d into home-assistant:dev Sep 30, 2019
9 checks passed
9 checks passed
CI Build #20190929.50 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
Dev automation moved this from Reviewer approved to Done Sep 30, 2019
@johnluetke johnluetke deleted the johnluetke:pihole-services branch Sep 30, 2019
@lock lock bot locked and limited conversation to collaborators Oct 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.