Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor template components to extract common routines #27064

merged 126 commits into from Nov 26, 2019


Copy link

grillp commented Sep 30, 2019

Breaking Change:



Refactored the tempalte components to pull out common code across all 8 template components.

Example entry for configuration.yaml (if applicable):


  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
grillp added 30 commits Sep 8, 2019
grillp added 3 commits Sep 30, 2019
@grillp grillp changed the title WIP: Refactored template components to extract common routines Refactored template components to extract common routines Oct 2, 2019
@MartinHjelmare MartinHjelmare changed the title Refactored template components to extract common routines Refactor template components to extract common routines Oct 4, 2019
Dev automation moved this from Needs review to Reviewer approved Nov 26, 2019

This comment has been minimized.

Copy link

balloob commented Nov 26, 2019

Very nice cleanup !

@balloob balloob merged commit 0088995 into home-assistant:dev Nov 26, 2019
10 checks passed
10 checks passed
CI Build #20191002.4 succeeded
CI (FullCheck Mypy) FullCheck Mypy succeeded
CI (FullCheck Pylint) FullCheck Pylint succeeded
CI (Overview CheckFormat) Overview CheckFormat succeeded
CI (Overview Lint) Overview Lint succeeded
CI (Overview Validate) Overview Validate succeeded
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
codecov/patch 100% of diff hit (target 94.31%)
codecov/project 94.32% (target 90%)
Dev automation moved this from Reviewer approved to Done Nov 26, 2019
@lock lock bot locked and limited conversation to collaborators Nov 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants
You can’t perform that action at this time.