Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in ecobee integration by bumping python-ecobee-api to 0.1.4 #27074

merged 1 commit into from Sep 30, 2019


Copy link

commented Sep 30, 2019


A bug in python-ecobee-api was causing tokens to never refresh, which meant that an hour after Home Assistant startup, the access token would expire and ecobee entities would stop updating. The bug has been caught in python-ecobee-api and the new version includes the fix.

Related issue (if applicable): fixes #27025

Pull request with documentation for (if applicable): N/A

Example entry for configuration.yaml (if applicable):



  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@project-bot project-bot bot added this to Needs review in Dev Sep 30, 2019
@marthoc marthoc changed the title Fix bug in ecobee integration by bumping pyecobee to 0.1.4 Fix bug in ecobee integration by bumping python-ecobee-api to 0.1.4 Sep 30, 2019
@cgarwood cgarwood merged commit d28980b into home-assistant:dev Sep 30, 2019
12 checks passed
12 checks passed
CI Build #20190930.32 succeeded
CI (FullCheck Mypy) FullCheck Mypy succeeded
CI (FullCheck Pylint) FullCheck Pylint succeeded
CI (Overview CheckFormat) Overview CheckFormat succeeded
CI (Overview Lint) Overview Lint succeeded
CI (Overview Validate) Overview Validate succeeded
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected.
codecov/project 94.31% (target 90%)
docs-missing Documentation ok.
Dev automation moved this from Needs review to Done Sep 30, 2019
@marthoc marthoc deleted the marthoc:bump-ecobee-version branch Sep 30, 2019
@lock lock bot locked and limited conversation to collaborators Oct 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
You can’t perform that action at this time.