Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some icons for Obihai #27075

Merged
merged 4 commits into from Oct 1, 2019

Conversation

@dshokouhi
Copy link
Contributor

commented Sep 30, 2019

Breaking Change:

Description:

Add some icons for Obihai

Related issue (if applicable): fixes #N/A

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#N/A

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: obihai
    host: 192.168.1.x

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.
dshokouhi added 3 commits Sep 30, 2019
Dev automation moved this from Needs review to Reviewer approved Oct 1, 2019
Copy link
Contributor

left a comment

LGTM, happy hacktoberfest!

@awarecan awarecan merged commit bce4923 into home-assistant:dev Oct 1, 2019
11 checks passed
11 checks passed
CI Build #20190930.41 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected.
Details
codecov/project 94.31% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Oct 1, 2019
@dshokouhi dshokouhi deleted the dshokouhi:obihai_icons branch Oct 1, 2019
@lock lock bot locked and limited conversation to collaborators Oct 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.