Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete here_travel_time dead code COORDINATE_SCHEMA #27090

Merged
merged 1 commit into from Oct 1, 2019

Conversation

@eifinger
Copy link
Contributor

commented Oct 1, 2019

Breaking Change:

No

Description:

Delete a redundant schema in here_travel_time. This is a remnant of the early development cycle of this integration.

Related issue (if applicable): N/A

Pull request with documentation for home-assistant.io (if applicable): N/A

Example entry for configuration.yaml (if applicable):

N/A

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@project-bot project-bot bot added this to Needs review in Dev Oct 1, 2019
@frenck frenck added the Hacktoberfest label Oct 1, 2019
Dev automation moved this from Needs review to Reviewer approved Oct 1, 2019
Copy link
Member

left a comment

Thanks!

@MartinHjelmare MartinHjelmare changed the title Delete dead code COORDINATE_SCHEMA Delete here_travel_time dead code COORDINATE_SCHEMA Oct 1, 2019
@MartinHjelmare MartinHjelmare merged commit 8d251c1 into home-assistant:dev Oct 1, 2019
11 checks passed
11 checks passed
CI Build #20191001.23 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
codecov/patch Coverage not affected when comparing a1997ee...f326bfe
Details
codecov/project 94.31% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Oct 1, 2019
@lock lock bot locked and limited conversation to collaborators Oct 2, 2019
@eifinger eifinger deleted the eifinger:here_travel_time branch Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.