Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add neural support to amazon polly #27101

merged 2 commits into from Oct 2, 2019


Copy link

commented Oct 1, 2019

This is my second attempt at this. I first created a dev environment and a branch within my fork and pushed the changes to it. Then I created a PR from the branch. Hopefully I did it right.

Please delete the old PR. I couldn't figure out how to fix the git issues with it: #26836

Breaking Change: None


Adds neural support. Neural only work with the proper combinations of features such as voice and region. See the official docs. I'll probably put a note about this in the hass docs PR I submit.

Related issue (if applicable): none

Pull request with documentation for (if applicable):

Can someone confirm this is correct before I spend a bunch of time trying to update the docs? I previously screwed that up too because of "rebasing".

Example entry for configuration.yaml (if applicable):

  - platform: amazon_polly
    aws_access_key_id: x
    aws_secret_access_key: x
    voice: Joanna
    sample_rate: 24000 
    engine: neural


  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@bbrendon bbrendon referenced this pull request Oct 2, 2019
2 of 2 tasks complete

This comment has been minimized.

Copy link
Contributor Author

commented Oct 2, 2019

added docs to initial comment. also home-assistant/

@bbrendon bbrendon referenced this pull request Oct 2, 2019
2 of 2 tasks complete
@frenck frenck removed the docs-missing label Oct 2, 2019
@MartinHjelmare MartinHjelmare changed the title amazon polly - add neural support Add neural support to amazon polly Oct 2, 2019
Dev automation moved this from Needs review to Reviewer approved Oct 2, 2019
@MartinHjelmare MartinHjelmare merged commit 8488b57 into home-assistant:dev Oct 2, 2019
11 checks passed
11 checks passed
CI Build #20191002.7 succeeded
CI (FullCheck Mypy) FullCheck Mypy succeeded
CI (FullCheck Pylint) FullCheck Pylint succeeded
CI (Overview CheckFormat) Overview CheckFormat succeeded
CI (Overview Lint) Overview Lint succeeded
CI (Overview Validate) Overview Validate succeeded
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 571ab5a...1fd2e47
codecov/project 94.31% (target 90%)
Dev automation moved this from Reviewer approved to Done Oct 2, 2019
@lock lock bot locked and limited conversation to collaborators Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
5 participants
You can’t perform that action at this time.