Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix colorTemperatureInKelvin in Alexa report when light is off #27107

Merged

Conversation

@ochlocracy
Copy link
Contributor

commented Oct 2, 2019

Description:

color_temp attribute is not available when light state is off. Therefore colorTemperatureInKelvin does not need to be reported to Alexa API in state change. Returning None prevents the property from being included when the light state is off.

Related issue (if applicable): fixes #26405

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
ochlocracy added 2 commits Oct 2, 2019
…vailable, prevents property from being reported with invalid value of 0.
@project-bot project-bot bot added this to Needs review in Dev Oct 2, 2019
@frenck frenck added the Hacktoberfest label Oct 2, 2019
Dev automation moved this from Needs review to Reviewer approved Oct 2, 2019
Copy link
Contributor

left a comment

Nice!

@awarecan awarecan merged commit 9c1feac into home-assistant:dev Oct 2, 2019
12 checks passed
12 checks passed
CI Build #20191002.5 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.31%)
Details
codecov/project 94.31% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Oct 2, 2019
@lock lock bot locked and limited conversation to collaborators Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.