Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump adb-shell to 0.0.3 #27108

Merged
merged 1 commit into from Oct 2, 2019

Conversation

@JeffLIrion
Copy link
Contributor

commented Oct 2, 2019

Description:

This bumps the adb-shell package to version 0.0.3. This should fix the issues using the Python ADB implementation for newer Android TV / Fire TV devices. Here is 1 report that this fixed the issue: https://community.home-assistant.io/t/community-hass-io-add-on-adb-android-debug-bridge/96375/295

Related issue (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
@fabaff
fabaff approved these changes Oct 2, 2019
Dev automation moved this from Needs review to Reviewer approved Oct 2, 2019
@fabaff fabaff merged commit 7d2a8b8 into home-assistant:dev Oct 2, 2019
12 checks passed
12 checks passed
CI Build #20191002.6 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 6b3ec7e...22f11de
Details
codecov/project 94.31% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Oct 2, 2019
@lock lock bot locked and limited conversation to collaborators Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.