Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Google Report State #27112

Merged
merged 7 commits into from Oct 3, 2019

Conversation

@balloob
Copy link
Member

commented Oct 2, 2019

Description:

Adds Google Report State functionality for Home Assistant Cloud:

  • Allow changing preference to enable/disable report state
  • Sync entities when report state changes
  • Sync entities when entity registry is updated and the entity is part of Google

To do:

  • Update to latest hass-nabucasa release after NabuCasa/hass-nabucasa#90 is merged
  • Frontend (non blocking for this PR)
  • Testing of the full chain

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
balloob and others added 5 commits Oct 2, 2019
@balloob balloob force-pushed the google-report-state branch from 1244ab5 to 932cbd8 Oct 2, 2019
balloob and others added 2 commits Oct 3, 2019
@pvizeli
pvizeli approved these changes Oct 3, 2019
@pvizeli pvizeli merged commit f184bf4 into dev Oct 3, 2019
9 of 12 checks passed
9 of 12 checks passed
Release This check was skipped
Details
Translation - Backend This check was skipped
Details
home-assistant-wheels This check was skipped
Details
CI Build #20191003.19 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
@delete-merged-branch delete-merged-branch bot deleted the google-report-state branch Oct 3, 2019
@lock lock bot locked and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.