Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation link URL for integrations in all manifests #27114

Merged
merged 1 commit into from Oct 2, 2019

Conversation

@frenck
Copy link
Member

commented Oct 2, 2019

Description:

Our website has changed the URL structure for integrations. This PR updates all manifests.

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable): n/a

Example entry for configuration.yaml (if applicable): n/a

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@frenck frenck requested review from syssi, zxdavb and home-assistant/core as code owners Oct 2, 2019
@project-bot project-bot bot added this to Needs review in Dev Oct 2, 2019
@frenck frenck added the Hacktoberfest label Oct 2, 2019
@frenck

This comment has been minimized.

Copy link
Member Author

commented Oct 2, 2019

Sorry for the massive ping/review requests on this... That happens automatically.

@frenck frenck referenced this pull request Oct 2, 2019
0 of 9 tasks complete
Copy link
Contributor

left a comment

ZHA looks good.

Dev automation moved this from Needs review to Reviewer approved Oct 2, 2019
@balloob

This comment has been minimized.

Copy link
Member

commented Oct 2, 2019

Does this update the scaffold template too?

@balloob balloob merged commit c7da781 into dev Oct 2, 2019
12 checks passed
12 checks passed
CI Build #20191002.30 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 8488b57...1999c8a
Details
codecov/project 94.32% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Oct 2, 2019
@delete-merged-branch delete-merged-branch bot deleted the frenck-2019-0228 branch Oct 2, 2019
@frenck

This comment has been minimized.

Copy link
Member Author

commented Oct 2, 2019

@balloob No, it does not. I've splitted this into 2 PR's. A big, but simple repetitive one (this one) and one for everything else: #27117

Just for keeping easier to review.

@lock lock bot locked and limited conversation to collaborators Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.