Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move ATTR_MODE to homeassistant.const #27118

merged 1 commit into from Oct 2, 2019


Copy link

commented Oct 2, 2019


Create a central definition of ATTR_MODE in homeassistant.const instead of defining it several times for each integration using it.

Related issue (if applicable): N/A

Pull request with documentation for (if applicable): N/A

Example entry for configuration.yaml (if applicable):



  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@eifinger eifinger requested review from danielperna84, fabaff, pvizeli, rytilahti, syssi and home-assistant/core as code owners Oct 2, 2019
@project-bot project-bot bot added this to Needs review in Dev Oct 2, 2019
@frenck frenck added the Hacktoberfest label Oct 2, 2019
fabaff approved these changes Oct 2, 2019
Copy link

left a comment


Dev automation moved this from Needs review to Reviewer approved Oct 2, 2019
@balloob balloob merged commit 04ead6f into home-assistant:dev Oct 2, 2019
12 checks passed
12 checks passed
CI Build #20191002.42 succeeded
CI (FullCheck Mypy) FullCheck Mypy succeeded
CI (FullCheck Pylint) FullCheck Pylint succeeded
CI (Overview CheckFormat) Overview CheckFormat succeeded
CI (Overview Lint) Overview Lint succeeded
CI (Overview Validate) Overview Validate succeeded
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.32%)
codecov/project 94.32% (target 90%)
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Oct 2, 2019
@lock lock bot locked and limited conversation to collaborators Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
5 participants
You can’t perform that action at this time.