Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable flaky/slow ecobee test #27125

Merged
merged 1 commit into from Oct 2, 2019

Conversation

Copy link
Member

left a comment

Just commenting about what needs to be done to fix the test.

@@ -116,6 +117,7 @@
assert result["description_placeholders"] == {"pin": "test-pin"}


@pytest.mark.skip(reason="Flaky/slow")
async def test_import_flow_triggered_but_no_ecobee_conf(hass):

This comment has been minimized.

Copy link
@MartinHjelmare

MartinHjelmare Oct 2, 2019

Member

We're missing patching in this test. We should patch the load json util.

Seems more setup is needed to complete this test too, eg populate hass.data.

@marthoc

This comment has been minimized.

Copy link
Contributor

commented Oct 2, 2019

I’m planning to take a look at the whole ecobee test suite soon so I’ll make sure to address this then.

@emontnemery emontnemery merged commit 0eb1d49 into home-assistant:dev Oct 2, 2019
12 checks passed
12 checks passed
CI Build #20191002.86 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 9c49b8d...0323a21
Details
codecov/project 94.32% (target 90%)
Details
docs-missing Documentation ok.
@emontnemery emontnemery deleted the emontnemery:ecobee_disable_test branch Oct 3, 2019
@lock lock bot locked and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.