Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unavailable climate entities in Alexa StateReport #27128

Merged

Conversation

@ochlocracy
Copy link
Contributor

commented Oct 2, 2019

Description:

Handles climate entities with unavailable state. Essentially ignores reporting AlexaThermostatController and AlexaTemperatureSensor properties and allows the Alexa.EndpointHealth to handle reporting the unavailable state. Preserves raising an error for unsupported states.

Added additional tests for reporting climate.state/thermostatMode to Alexa.

Related issue (if applicable): fixes #27027

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
ochlocracy added 2 commits Oct 2, 2019
…properties if climate state is unavailable. Preserves raising an error for UnsupportedProperty, and allows Alexa.EndpointHealth to handle the unavailable state.
@balloob
balloob approved these changes Oct 2, 2019
Copy link
Member

left a comment

🎉 Amazing !

@balloob

This comment has been minimized.

Copy link
Member

commented Oct 2, 2019

That's a great first contribution. Welcome to the Home Assistant community 🐬

@balloob balloob merged commit 6dfeed6 into home-assistant:dev Oct 2, 2019
12 checks passed
12 checks passed
CI Build #20191002.95 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.31%)
Details
codecov/project 94.32% (target 90%)
Details
docs-missing Documentation ok.
@lock lock bot locked and limited conversation to collaborators Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.