Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device trigger support to sensor entities #27133

Merged
merged 3 commits into from Oct 3, 2019

Conversation

@emontnemery
Copy link
Contributor

commented Oct 2, 2019

Description:

Add device trigger support to sensor entities.
This includes trigger part from #26854

This PR is intended as a step towards home-assistant/architecture#178

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@balloob
balloob approved these changes Oct 2, 2019
def assert_lists_same(a, b):
"""Compare two lists, ignoring order."""
assert collections.Counter([hashdict(i) for i in a]) == collections.Counter(
[hashdict(i) for i in b]
)
Comment for lines +1131  – +1135

This comment has been minimized.

Copy link
@emontnemery

emontnemery Oct 2, 2019

Author Contributor

Added to compare lists with different order since the order of automations is not deterministic when we have automations from different domains.

@emontnemery emontnemery merged commit 3e99743 into home-assistant:dev Oct 3, 2019
11 checks passed
11 checks passed
CI Build #20191002.112 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.33%)
Details
codecov/project 94.33% (target 90%)
Details
@emontnemery emontnemery deleted the emontnemery:device_trigger_sensor branch Oct 3, 2019
@lock lock bot locked and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.