Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add above and below to sensor device trigger extra_fields #27160


Copy link

commented Oct 3, 2019


Add above and below to sensor trigger extra_fields.
This is missing from PR #27133 which introduces device triggers for sensors.

Once frontend PR home-assistant/home-assistant-polymer#3721 is merged we will then get a UI like this:


  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
balloob approved these changes Oct 3, 2019
@emontnemery emontnemery merged commit 9902209 into home-assistant:dev Oct 3, 2019
10 checks passed
10 checks passed
CI Build #20191003.50 succeeded
CI (FullCheck Mypy) FullCheck Mypy succeeded
CI (FullCheck Pylint) FullCheck Pylint succeeded
CI (Overview CheckFormat) Overview CheckFormat succeeded
CI (Overview Lint) Overview Lint succeeded
CI (Overview Validate) Overview Validate succeeded
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
cla-bot Everyone involved has signed the CLA
docs-missing Documentation ok.
@frenck frenck added the Hacktoberfest label Oct 3, 2019
@lock lock bot locked and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
4 participants
You can’t perform that action at this time.