Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle all single zone thermostats #27168

Merged
merged 1 commit into from Oct 4, 2019

Conversation

@zxdavb
Copy link
Contributor

commented Oct 3, 2019

Breaking Change:

None known.

Description:

Bugfix, to include all single zone systems, RoundWireless in addition to RoundModulation.

Tweaks debug text slightly to aid debugging.

Related issue (if applicable): fixes #27161

Pull request with documentation for home-assistant.io (if applicable): N/A

** Example entry for configuration.yaml (if applicable): N/A

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@zxdavb zxdavb marked this pull request as ready for review Oct 3, 2019
@balloob

This comment has been minimized.

Copy link
Member

commented Oct 3, 2019

Should this be part of 0.100 ?

@balloob
balloob approved these changes Oct 3, 2019
@zxdavb

This comment has been minimized.

Copy link
Contributor Author

commented Oct 3, 2019

Should this be part of 0.100 ?

No, I'd prefer ASAP - is a small PR & fixes a show stopper.

If I've done it right, it was based upon 0.99.3, but should merge OK into 0.100 if you would prefer.

@zxdavb

This comment has been minimized.

Copy link
Contributor Author

commented Oct 4, 2019

Do I add cherry-picked label?

@balloob

This comment has been minimized.

Copy link
Member

commented Oct 4, 2019

I wasn't planning another hot fix release. Especially since the beta is cut, it's a bunch more work to do a hot fix.

@balloob balloob merged commit b63b207 into home-assistant:rc Oct 4, 2019
12 checks passed
12 checks passed
CI Build #20191003.58 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected.
Details
codecov/project 94.3% (target 90%)
Details
docs-missing Documentation ok.
@balloob

This comment has been minimized.

Copy link
Member

commented Oct 4, 2019

We control what goes into hotfixes or betas via milestones btw.

@balloob

This comment has been minimized.

Copy link
Member

commented Oct 4, 2019

This should not have gone to the rc branch, but the dev branch. cherry picking it back.

balloob added a commit that referenced this pull request Oct 4, 2019
@zxdavb zxdavb deleted the zxdavb:evohome_bugfix branch Oct 4, 2019
@zxdavb zxdavb referenced this pull request Oct 4, 2019
9 of 9 tasks complete
@zxdavb

This comment has been minimized.

Copy link
Contributor Author

commented Oct 4, 2019

@balloob I'm confused - is this going into 0.100 or 0.101?

It is a small fix to correct a show-stopper bug, should really going into 0.100. I can reduce it to 1 line if required.

@frenck frenck referenced this pull request Oct 4, 2019
@frenck frenck added the Hacktoberfest label Oct 4, 2019
@balloob balloob added this to the 0.100 milestone Oct 4, 2019
@balloob

This comment has been minimized.

Copy link
Member

commented Oct 4, 2019

That's what I wrote at #27168 (comment) albeit a bit short.

We use milestones to control to which release a PR gets cherry picked.

@lock lock bot locked and limited conversation to collaborators Oct 5, 2019
@balloob balloob removed this from the 0.100 milestone Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.