New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AC mode to heat_control component #2719

Merged
merged 1 commit into from Aug 3, 2016

Conversation

Projects
None yet
2 participants
@mtreinish
Contributor

mtreinish commented Aug 3, 2016

Description:
Add an air conditioner mode to the heat_control component. The same concept and operation used for plug in heaters applies equally well to in-wall or window AC units except the logic is reversed.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#723

Example entry for configuration.yaml (if applicable):

thermostat:
  platform: heat_control
  name: Study
  heater: switch.study_heater
  target_sensor: sensor.study_temperature
  min_temp: 15
  max_temp: 21
  target_temp: 15
  ac_mode: True

Checklist:

If user exposed functionality or configuration variables are added/changed:

If code communicates with devices, web services, or a:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

This commit adds a new option to the heat_control component, ac_mode.
When set to true, this treats the toggle device as a cooler instead
of a heater. The concept being if you have a window or in-wall ac
unit that doesn't have a built-in thermostat having the home assistant
implemented thermostat would be as useful as for space heaters.

Add AC mode to heat_control component
This commit adds a new option to the heat_control component, ac_mode.
When set to true, this treats the toggle device as a cooler instead
of a heater. The concept being if you have a window or in-wall ac
unit that doesn't have a built-in thermostat having the home assistant
implemented thermostat would be as useful as for space heaters.
@mtreinish

This comment has been minimized.

Show comment
Hide comment
@mtreinish

mtreinish Aug 3, 2016

Contributor

I also considered doing this as a new component, but I figured this approach was better than duplicating the entire module to just swap the comparisons.

Contributor

mtreinish commented Aug 3, 2016

I also considered doing this as a new component, but I figured this approach was better than duplicating the entire module to just swap the comparisons.

mtreinish added a commit to mtreinish/home-assistant.io that referenced this pull request Aug 3, 2016

Add ac_mode option to thermostat.heat_control docs
This commit adds the heat_control option add in change:
home-assistant/home-assistant#2719 to the documentation for that
component.
@balloob

This comment has been minimized.

Show comment
Hide comment
@balloob

balloob Aug 3, 2016

Member

Looks good! 🐬

Member

balloob commented Aug 3, 2016

Looks good! 🐬

@balloob balloob merged commit 94acda2 into home-assistant:dev Aug 3, 2016

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.0003%) to 93.554%
Details
farcy approves! Wicked awesome!

balloob added a commit to home-assistant/home-assistant.io that referenced this pull request Aug 3, 2016

Add ac_mode option to thermostat.heat_control docs (#723)
This commit adds the heat_control option add in change:
home-assistant/home-assistant#2719 to the documentation for that
component.

@mtreinish mtreinish deleted the mtreinish:add_ac_mode branch Aug 3, 2016

@home-assistant home-assistant locked and limited conversation to collaborators Mar 17, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.