Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validation when automation is saved from frontend #27195

Merged
merged 1 commit into from Oct 4, 2019

Conversation

@emontnemery
Copy link
Contributor

commented Oct 4, 2019

Description:

Fix validation when automation is saved from frontend (regression caused by #26910).

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@emontnemery emontnemery added this to the 0.100 milestone Oct 4, 2019
@emontnemery emontnemery requested a review from home-assistant/core as a code owner Oct 4, 2019
@project-bot project-bot bot added this to Needs review in Dev Oct 4, 2019
@frenck frenck added the Hacktoberfest label Oct 4, 2019
@balloob
balloob approved these changes Oct 4, 2019
Dev automation moved this from Needs review to Reviewer approved Oct 4, 2019
@balloob balloob merged commit e27051a into home-assistant:dev Oct 4, 2019
12 checks passed
12 checks passed
CI Build #20191004.57 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.29%)
Details
codecov/project 94.29% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Oct 4, 2019
@lock lock bot locked and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.