Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ecobee binary sensor and sensor unique ids #27208

Merged
merged 2 commits into from Oct 4, 2019

Conversation

@marthoc
Copy link
Contributor

commented Oct 4, 2019

Description:

As it turns out the ecobee API documentation has a different interpretation of the word "unique" than I do. What they mean to say is "unique to a particular thermostat". When a user has multiple thermostats (as @arsaboo does) the value I used for unique_id for the sensors built into the thermostat is no longer unique. I've added the thermostat serial number in this situation which will make the value truly unique across thermostats. @arsaboo is testing.

Related issue (if applicable): N/A

Pull request with documentation for home-assistant.io (if applicable): N/A

Example entry for configuration.yaml (if applicable):

N/A

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
marthoc added 2 commits Oct 4, 2019
@balloob
balloob approved these changes Oct 4, 2019
Dev automation moved this from Needs review to Reviewer approved Oct 4, 2019
@balloob balloob added this to the 0.100 milestone Oct 4, 2019
@arsaboo

This comment has been minimized.

Copy link
Contributor

commented Oct 4, 2019

Just tested this and can confirm that everything works fine after the fix...thanks for the quick fix 🎉

@frenck frenck added the Hacktoberfest label Oct 4, 2019
@balloob balloob merged commit c62d1a7 into home-assistant:dev Oct 4, 2019
12 checks passed
12 checks passed
CI Build #20191004.92 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing e5a2e18...427e184
Details
codecov/project 94.3% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Oct 4, 2019
balloob added a commit that referenced this pull request Oct 5, 2019
* Fix sensor unique id

* Fix binary sensor unique id
@lock lock bot locked and limited conversation to collaborators Oct 5, 2019
@marthoc marthoc deleted the marthoc:ecobee-device-registry-fix branch Oct 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
5 participants
You can’t perform that action at this time.