Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump adb-shell to 0.0.4; bump androidtv to 0.0.30 #27224

merged 1 commit into from Oct 5, 2019


Copy link

commented Oct 5, 2019


Improve support for newer devices using the Python ADB implementation (as opposed to the ADB server approach).

Related issue (if applicable): This fixes a bug where the ADB connection attempt would fail but adb-shell would incorrectly report to androidtv that the connection was available, and when androidtv would send an ADB command it would cause an exception. With this fix in place, if the ADB connection attempt fails then a PlatformNotReady exception will be raised, which is the desired behavior.

This also applies to the case that a re-connect attempt fails, which could occur during a reboot of the device.

Any chance this bug fix could be included in 0.100?


  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
@project-bot project-bot bot added this to Needs review in Dev Oct 5, 2019
@JeffLIrion JeffLIrion marked this pull request as ready for review Oct 5, 2019
Dev automation moved this from Needs review to Reviewer approved Oct 5, 2019
balloob approved these changes Oct 5, 2019
@balloob balloob merged commit 0b838f8 into home-assistant:dev Oct 5, 2019
12 checks passed
12 checks passed
CI Build #20191005.28 succeeded
CI (FullCheck Mypy) FullCheck Mypy succeeded
CI (FullCheck Pylint) FullCheck Pylint succeeded
CI (Overview CheckFormat) Overview CheckFormat succeeded
CI (Overview Lint) Overview Lint succeeded
CI (Overview Validate) Overview Validate succeeded
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing a8567a7...2947566
codecov/project 94.29% (target 90%)
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Oct 5, 2019

This comment has been minimized.

Copy link
Contributor Author

commented Oct 5, 2019

@balloob thanks! Any chance this could be included in 0.100?

@balloob balloob added this to the 0.100 milestone Oct 5, 2019
balloob added a commit that referenced this pull request Oct 5, 2019
@frenck frenck added the Hacktoberfest label Oct 6, 2019
@lock lock bot locked and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
4 participants
You can’t perform that action at this time.