Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix onvif PTZ service freeze #27250

Merged
merged 1 commit into from Oct 6, 2019

Conversation

@skgsergio
Copy link
Contributor

commented Oct 6, 2019

Description:

Using onvif service camera.onvif_ptz freezes HA. This is due a call to a non-async function extract_entity_ids inside an async service handler.

The fix is pretty easy and is just calling async_extract_entity_ids instead.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox.
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@project-bot project-bot bot added this to Needs review in Dev Oct 6, 2019
@skgsergio skgsergio changed the title Fix onvif PTZ freeze Fix onvif PTZ service freeze Oct 6, 2019
Copy link
Member

left a comment

Thanks!

Dev automation moved this from Needs review to Reviewer approved Oct 6, 2019
@MartinHjelmare MartinHjelmare merged commit 6cc71db into home-assistant:dev Oct 6, 2019
12 checks passed
12 checks passed
CI Build #20191006.49 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 1ecc883...f627080
Details
codecov/project 94.26% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Oct 6, 2019
@MartinHjelmare MartinHjelmare added this to the 0.100 milestone Oct 6, 2019
@balloob balloob removed the invalid label Oct 6, 2019
@skgsergio skgsergio deleted the skgsergio:fix-onvif-ptz branch Oct 6, 2019
@lock lock bot locked and limited conversation to collaborators Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.