Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Plex media_player.play_media service #27278

Merged
merged 4 commits into from Oct 7, 2019

Conversation

@jjlawren
Copy link
Contributor

commented Oct 7, 2019

Description:

Fix the media_player.play_media service. Some JSON parameters in media_content_id are now optional, which will be documented.

Related issue (if applicable): fixes #19623

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#TODO

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@project-bot project-bot bot added this to Needs review in Dev Oct 7, 2019
@jjlawren

This comment has been minimized.

Copy link
Contributor Author

commented Oct 7, 2019

Hey @balloob, pinging you as requested. Hoping to review and fit this into 0.100 for everyone that's waiting patiently.

@balloob balloob added this to the 0.100 milestone Oct 7, 2019
@balloob
balloob approved these changes Oct 7, 2019
Copy link
Member

left a comment

🎉 amazing. Tagging it for 0.100

Dev automation moved this from Needs review to Reviewer approved Oct 7, 2019
@balloob balloob merged commit 0915d92 into home-assistant:dev Oct 7, 2019
12 checks passed
12 checks passed
CI Build #20191007.9 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 3b9f006...ebc2866
Details
codecov/project 94.24% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Oct 7, 2019
@frenck

This comment has been minimized.

Copy link
Member

commented Oct 7, 2019

Nicely done @jjlawren ❤️

@jjlawren jjlawren deleted the jjlawren:plex_update_play_media branch Oct 7, 2019
balloob added a commit that referenced this pull request Oct 8, 2019
* First attempt to fix play_media

* More changes to media playback

* Use playqueues, clean up play_media

* Use similar function name, add docstring
@lock lock bot locked and limited conversation to collaborators Oct 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.