Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Plex manual config flow step #27291

Merged
merged 1 commit into from Oct 7, 2019

Conversation

@jjlawren
Copy link
Contributor

commented Oct 7, 2019

Description:

Remove manual configuration flow step. Manual configuration will only be available via YAML configuration.

Not breaking as this feature was never officially released.

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10655

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@jjlawren

This comment has been minimized.

Copy link
Contributor Author

commented Oct 7, 2019

Hey @balloob, also as requested. It was a big more invasive on the tests than I expected, but it looks ok. Up to you if you want to review/merge before the first Plex config flow release in 0.100.

@balloob balloob added this to the 0.100 milestone Oct 7, 2019
@balloob
balloob approved these changes Oct 7, 2019
Copy link
Member

left a comment

Awesome.

@balloob balloob merged commit a3c9844 into home-assistant:dev Oct 7, 2019
12 checks passed
12 checks passed
CI Build #20191007.53 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.25%)
Details
codecov/project 94.25% (target 90%)
Details
docs-missing Documentation ok.
@jjlawren jjlawren referenced this pull request Oct 7, 2019
2 of 2 tasks complete
@jjlawren jjlawren deleted the jjlawren:plex_remove_manual_flow branch Oct 7, 2019
balloob added a commit that referenced this pull request Oct 8, 2019
@lock lock bot locked and limited conversation to collaborators Oct 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.