Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve speed websocket sends messages #27295

Merged
merged 2 commits into from Oct 8, 2019

Conversation

@balloob
Copy link
Member

commented Oct 7, 2019

Description:

Based on the implementation of websocket_client.send_json we can just use send_str, which saves us an await. This makes sending data slightly faster.

Related issue (if applicable): zachowj/node-red-contrib-home-assistant-websocket#153

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
@balloob balloob requested a review from home-assistant/core as a code owner Oct 7, 2019
@balloob balloob added this to the 0.100 milestone Oct 7, 2019
@balloob balloob merged commit c9e26b6 into dev Oct 8, 2019
11 checks passed
11 checks passed
CI Build #20191007.87 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.25%)
Details
codecov/project 94.27% (target 90%)
Details
@delete-merged-branch delete-merged-branch bot deleted the slightly-faster-ws-send branch Oct 8, 2019
balloob added a commit that referenced this pull request Oct 8, 2019
* Improve speed websocket sends messages

* return -> continue
@lock lock bot locked and limited conversation to collaborators Oct 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.