Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix connection issues with withings API by switching to a maintained codebase #27310

Merged
merged 3 commits into from Oct 8, 2019

Conversation

@vangorra
Copy link
Contributor

commented Oct 8, 2019

Breaking Change:

No breaking changes.

Description:

Shortly after inclusion into home assistant, the withings API started requiring extra data when authorizing. The client code the withings component uses was maintained. So we have switched over to a maintained api client.

Related issue (if applicable): fixes #
fixes #26716

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.
…ed client codebase.
@balloob
balloob approved these changes Oct 8, 2019
@balloob

This comment has been minimized.

Copy link
Member

commented Oct 8, 2019

Ok to merge when you run script/gen_requirements_all.py

@MartinHjelmare MartinHjelmare changed the title Fixing connection issues with withings API by switching to a maintained codebase Fix connection issues with withings API by switching to a maintained codebase Oct 8, 2019
@MartinHjelmare MartinHjelmare added this to Second opinion wanted in Dev Oct 8, 2019
@MartinHjelmare MartinHjelmare moved this from Second opinion wanted to Reviewer approved in Dev Oct 8, 2019
@MartinHjelmare MartinHjelmare moved this from Reviewer approved to Needs review in Dev Oct 8, 2019
Dev automation moved this from Needs review to Reviewer approved Oct 8, 2019
Copy link
Member

left a comment

Can be merged when build passes.

@MartinHjelmare MartinHjelmare merged commit 0714763 into home-assistant:dev Oct 8, 2019
11 checks passed
11 checks passed
CI Build #20191008.61 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.27%)
Details
codecov/project 94.27% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Oct 8, 2019
@MartinHjelmare

This comment has been minimized.

Copy link
Member

commented Oct 8, 2019

Should this go into 0.100?

@vangorra

This comment has been minimized.

Copy link
Contributor Author

commented Oct 8, 2019

Yes

@balloob balloob added this to the 0.100 milestone Oct 8, 2019
@lock lock bot locked and limited conversation to collaborators Oct 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
5 participants
You can’t perform that action at this time.