Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google: Report all states on activating report state #27312

Merged
merged 1 commit into from Oct 8, 2019

Conversation

@balloob
Copy link
Member

commented Oct 8, 2019

Description:

When state reporting is activated for Google, report all states once so that they have the latest info.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@probot-home-assistant

This comment has been minimized.

Copy link

commented Oct 8, 2019

Hey there home-assistant/cloud, mind taking a look at this pull request as its been labeled with a integration (google_assistant) you are listed as a codeowner for? Thanks!

@MartinHjelmare MartinHjelmare added this to Needs review in Dev Oct 8, 2019
@balloob balloob added this to the 0.100 milestone Oct 8, 2019
@balloob balloob merged commit a51e0d7 into dev Oct 8, 2019
11 of 12 checks passed
11 of 12 checks passed
codecov/patch 92.3% of diff hit (target 94.27%)
Details
CI Build #20191008.10 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/project 94.27% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Needs review to Done Oct 8, 2019
@delete-merged-branch delete-merged-branch bot deleted the report-state-on-activate branch Oct 8, 2019
balloob added a commit that referenced this pull request Oct 8, 2019
@lock lock bot locked and limited conversation to collaborators Oct 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
2 participants
You can’t perform that action at this time.