Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Proxmox VE integration #27315

Merged
merged 5 commits into from Nov 22, 2019
Merged

Add Proxmox VE integration #27315

merged 5 commits into from Nov 22, 2019

Conversation

@K4ds3
Copy link
Contributor

K4ds3 commented Oct 8, 2019

Breaking Change:

Added an integration for Proxmox VE

Description:

Integration to access Proxmox data

Related issue (if applicable): -

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10660

Example entry for configuration.yaml (if applicable):

# Example configuration.yaml entry
proxmox:
  - host: IP_ADDRESS
    username: USERNAME
    password: PASSWORD
    nodes:
      - node: NODE_NAME
        vms:
          - VM_ID
        containers:
          - CONTAINER_ID

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@homeassistant

This comment has been minimized.

Copy link
Contributor

homeassistant commented Oct 8, 2019

Hi @K4ds3,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@homeassistant homeassistant added cla-signed and removed cla-needed labels Oct 8, 2019
@K4ds3 K4ds3 mentioned this pull request Oct 8, 2019
2 of 2 tasks complete
@MartinHjelmare MartinHjelmare changed the title Added Proxmox VE integration Add Proxmox VE integration Oct 8, 2019
Copy link
Member

MartinHjelmare left a comment

Generally looks good. Some small fixes needed.

.coveragerc Outdated Show resolved Hide resolved
homeassistant/components/proxmoxve/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/proxmoxve/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/proxmoxve/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/proxmoxve/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/proxmoxve/binary_sensor.py Outdated Show resolved Hide resolved
homeassistant/components/proxmoxve/binary_sensor.py Outdated Show resolved Hide resolved
homeassistant/components/proxmoxve/binary_sensor.py Outdated Show resolved Hide resolved
K4ds3 added 2 commits Oct 8, 2019
@K4ds3 K4ds3 requested a review from MartinHjelmare Oct 8, 2019
@MartinHjelmare MartinHjelmare added this to Review in progress in Dev Oct 8, 2019
@K4ds3

This comment has been minimized.

Copy link
Contributor Author

K4ds3 commented Nov 21, 2019

Pylint fails since I'm using a broad catch, is that a real problem? I want to prevent one of the libraries proxmoxer is using for connecting to proxmox throwing an exception which isn't handled by my code

Dev automation moved this from Review in progress to Reviewer approved Nov 22, 2019
Copy link
Member

MartinHjelmare left a comment

Looks good! Do you want to add some more specific error handling?

@K4ds3

This comment has been minimized.

Copy link
Contributor Author

K4ds3 commented Nov 22, 2019

Looks good! Do you want to add some more specific error handling?

I've looked into the library documentation and it looks like there shouldn't be other exceptions than the already handled AuthenticationError! 😃

@MartinHjelmare MartinHjelmare merged commit 829e0a7 into home-assistant:dev Nov 22, 2019
11 checks passed
11 checks passed
CI #20191122.19 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 15870e0...d93019a
Details
codecov/project 94.47% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Nov 22, 2019
@lock lock bot locked and limited conversation to collaborators Nov 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.