Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Plex external auth for single server #27326

Merged
merged 1 commit into from Oct 8, 2019

Conversation

@jjlawren
Copy link
Contributor

commented Oct 8, 2019

Description:

The Plex external auth config flow fails when a single Plex server is connected to the account. I switched my testing environment to have multiple servers during development and added a feature that broke the single server use case.

This is a fix for beta functionality in 0.100 and needs to be merged before release.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
@MartinHjelmare MartinHjelmare added this to the 0.100 milestone Oct 8, 2019
@balloob balloob merged commit df8bf51 into home-assistant:dev Oct 8, 2019
12 checks passed
12 checks passed
CI Build #20191008.49 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 7a57c3a...3e5c5af
Details
codecov/project 94.27% (target 90%)
Details
docs-missing Documentation ok.
@jjlawren jjlawren deleted the jjlawren:plex_flow_fix_single_server branch Oct 8, 2019
balloob added a commit that referenced this pull request Oct 8, 2019
@lock lock bot locked and limited conversation to collaborators Oct 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.