Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix return values of preset_mode(s) properties #27751

Merged
merged 1 commit into from Nov 22, 2019
Merged

Conversation

@akasma74
Copy link
Contributor

akasma74 commented Oct 16, 2019

It is incorrect to return None as a result of proprety call because in such a case state_attr call will return None as well, which means "Unknown attribute".
Instead for preset_mode(s) PRESET_NONE constant should be used for consistency.

Breaking Change:

Description:

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
It is incorrect to return None as a result of proprety call because in such a case state_attr call will return None as well, which means "Unknown attribute".
Instead for preset_mode(s) PRESET_NONE constant should be used for consistency.
@project-bot project-bot bot added this to Needs review in Dev Oct 16, 2019
@MartinHjelmare MartinHjelmare changed the title fixing return values of preset_mode(s) properties Fix return values of preset_mode(s) properties Oct 17, 2019
@akasma74

This comment has been minimized.

Copy link
Contributor Author

akasma74 commented Oct 23, 2019

Devs, do I need to do anything else or it's ready to be merged?

@MartinHjelmare MartinHjelmare requested a review from pvizeli Oct 23, 2019
Dev automation moved this from Needs review to Reviewer approved Nov 22, 2019
Copy link
Member

Santobert left a comment

Looks good to me 👍

@frenck
frenck approved these changes Nov 22, 2019
Copy link
Member

frenck left a comment

I agree, thanks @akasma74! 👍

@frenck frenck merged commit a977f39 into home-assistant:dev Nov 22, 2019
12 checks passed
12 checks passed
CI Build #20191016.66 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.41%)
Details
codecov/project 94.41% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Nov 22, 2019
@lock lock bot locked and limited conversation to collaborators Nov 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.