Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move imports in owntracks component #27780

Merged
merged 10 commits into from Nov 18, 2019

Conversation

@Quentame
Copy link
Contributor

Quentame commented Oct 17, 2019

Breaking Change:

None

Description:

Moved import from function to top-level as requested in #27284

Related issue (if applicable): #27284

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
@Quentame Quentame force-pushed the Quentame:owntracks/move_imports branch 3 times, most recently from 390af82 to 9f0bd04 Oct 21, 2019
@Quentame Quentame force-pushed the Quentame:owntracks/move_imports branch 4 times, most recently from 7a08998 to f47251a Oct 28, 2019
@Quentame Quentame force-pushed the Quentame:owntracks/move_imports branch from f47251a to 3869e15 Oct 31, 2019
@home-assistant home-assistant deleted a comment from homeassistant Oct 31, 2019
.coveragerc Outdated Show resolved Hide resolved
@Quentame Quentame force-pushed the Quentame:owntracks/move_imports branch 2 times, most recently from a1b1ad0 to 37d092b Nov 5, 2019
@Quentame

This comment has been minimized.

Copy link
Contributor Author

Quentame commented Nov 8, 2019

As I understand the codecov/patch, I have to make the all the config flow tests because it needs 100% coverage.

I'll do in an other PR, and rebase this one after that.

Am I right ?

@MartinHjelmare

This comment has been minimized.

@Quentame Quentame force-pushed the Quentame:owntracks/move_imports branch from 37d092b to 41b18c6 Nov 8, 2019
@Quentame

This comment has been minimized.

Copy link
Contributor Author

Quentame commented Nov 9, 2019

Okey, still, I've added config flow tests here #28644.
But still something odd with the Codecov.

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Nov 9, 2019

It's 16 lines of the diff that are included for coverage calculation and 3 out of those are missed. This makes the calculation 81.25 %. So I think codecov calculates correctly.

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Nov 9, 2019

Make the change above and we can merge.

@Quentame

This comment has been minimized.

Copy link
Contributor Author

Quentame commented Nov 9, 2019

Will do, actually I’ve tried to mock the ImportError by multiple means but didn’t work (also opened a stackoverflow 😬).

Thanks !

@Quentame Quentame force-pushed the Quentame:owntracks/move_imports branch from a7bde41 to 07f4bc6 Nov 10, 2019
@Quentame Quentame mentioned this pull request Nov 11, 2019
4 of 5 tasks complete
@Quentame Quentame force-pushed the Quentame:owntracks/move_imports branch from 07f4bc6 to 0963714 Nov 11, 2019
@Quentame

This comment has been minimized.

Copy link
Contributor Author

Quentame commented Nov 12, 2019

Reviewed and rebased

Quentame added 10 commits Oct 17, 2019
@Quentame Quentame force-pushed the Quentame:owntracks/move_imports branch from 0963714 to 1a557f8 Nov 18, 2019
@Quentame

This comment has been minimized.

Copy link
Contributor Author

Quentame commented Nov 18, 2019

#27780 (comment) : I've made the change @MartinHjelmare , can we merge ?

It will fixes #27284

@Quentame Quentame mentioned this pull request Nov 18, 2019
517 of 518 tasks complete
Copy link
Member

MartinHjelmare left a comment

Good!

Dev automation moved this from Needs review to Reviewer approved Nov 18, 2019
@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Nov 18, 2019

I'll merge with codecov failing on the diff. It's a small diff for code under test.

@MartinHjelmare MartinHjelmare merged commit eb23846 into home-assistant:dev Nov 18, 2019
10 of 11 checks passed
10 of 11 checks passed
codecov/patch 85.71% of diff hit (target 94.44%)
Details
CI Build #20191118.21 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/project 94.45% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Nov 18, 2019
@Quentame Quentame deleted the Quentame:owntracks/move_imports branch Nov 18, 2019
@lock lock bot locked and limited conversation to collaborators Nov 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.