Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move imports in braviatv component #27855

Merged
merged 4 commits into from Nov 16, 2019
Merged

Conversation

@Bouni
Copy link
Contributor

Bouni commented Oct 18, 2019

Breaking Change:

None

Description:

Moved import from function to top-level as requested in #27284

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

Note: imports sorted using isort

@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Oct 18, 2019

Hey there @robbiet480, mind taking a look at this pull request as its been labeled with a integration (braviatv) you are listed as a codeowner for? Thanks!

@@ -2,10 +2,11 @@
import ipaddress
import logging

from braviarc import braviarc

This comment has been minimized.

Copy link
@pvizeli

pvizeli Oct 18, 2019

Member

Let import BraviaRC directly?

@Bouni

This comment has been minimized.

Copy link
Contributor Author

Bouni commented Oct 24, 2019

@pvizeli I misunderstood you request for direct import in the first place but fixed it a few minutes ago.
Now Black fails but if I run Black locally all seems to be fine!?

black homeassistant/components/braviatv/media_player.py
All done! ✨ 🍰 ✨
1 file left unchanged.

Is there a way to trigger a new CI run?

@MartinHjelmare

This comment has been minimized.

Copy link
Member

MartinHjelmare commented Nov 4, 2019

Please rebase on latest dev branch to let the build pass.

Bouni added 4 commits Oct 18, 2019
@Bouni Bouni force-pushed the Bouni:move_braviatv_imports branch from d0a0d59 to 4831918 Nov 4, 2019
@fabaff
fabaff approved these changes Nov 16, 2019
Dev automation moved this from Needs review to Reviewer approved Nov 16, 2019
@fabaff fabaff merged commit afbd966 into home-assistant:dev Nov 16, 2019
11 checks passed
11 checks passed
CI Build #20191104.9 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing cb2f42b...4831918
Details
codecov/project 94.36% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Nov 16, 2019
pull bot added a commit to KoHcoJlb/home-assistant that referenced this pull request Nov 16, 2019
* Move imports in braviatv component

* import braviarc directly

* fixed import

* directly import BraviaRC
KJonline added a commit to KJonline/home-assistant that referenced this pull request Nov 16, 2019
* dev: (200 commits)
  Truncate sensor state values (home-assistant#28788)
  Fix broken postnl sensor (home-assistant#28794)
  Move imports in braviatv component (home-assistant#27855)
  Add ombi password authentication option (home-assistant#28742)
  Lint exclusions (home-assistant#28655)
  Upgrade pylint, tweak config (home-assistant#28798)
  Bump pyHik library to 0.2.5 for id, tamper fixes (home-assistant#28807)
  Upgrade sqlalchemy to 1.3.11 (home-assistant#28721)
  Fix Repetier integration entity indexing (home-assistant#28766)
  Updated frontend to 20191115.0 (home-assistant#28797)
  [ci skip] Translation update
  Add support for Hisense AEH-W4A1 wifi module (AC remote control) (home-assistant#28641)
  Fix changing venstar operation_mode (home-assistant#28754)
  Fix Swisscom empty response received (home-assistant#28782)
  Fix HomematicIP Cloud Alarm Control Panel support for basic mode (home-assistant#28778)
  Change keys for Samsung TV next and prev track command (home-assistant#28213)
  Change unique id for SAJ sensor based on device SN (home-assistant#28663)
  bump home mitemp_bt to 0.0.3. It has an important bugfix for reading … (home-assistant#28765)
  Convert Tesla to Async (home-assistant#28748)
  Bump pytest to 5.2.3 (home-assistant#28785)
  ...

# Conflicts:
#	homeassistant/generated/config_flows.py
#	script/gen_requirements_all.py
thomasgermain added a commit to thomasgermain/home-assistant that referenced this pull request Nov 16, 2019
* Move imports in braviatv component

* import braviarc directly

* fixed import

* directly import BraviaRC
@lock lock bot locked and limited conversation to collaborators Nov 17, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.