Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Netatmo camera services #27970

Merged
merged 31 commits into from Nov 6, 2019
Merged

Add Netatmo camera services #27970

merged 31 commits into from Nov 6, 2019

Conversation

ssenart
Copy link
Contributor

@ssenart ssenart commented Oct 20, 2019

Description:

Implement services for Netatmo camera:

  • enable_motion_detection.
  • disable_motion_detection.

Create new services for Netatmo Presence camera:

  • set_light_auto : Set flood light in automatic mode.
  • set_light_on : Set flood light on.
  • set_light_off : Set flood light off.

Additionally, add new state attributes of cameras.

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10907

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

…et_light_off) to control its internal flood light status.
…et_light_off) to control its internal flood light status.
…into netatmo

# Conflicts:
#	homeassistant/components/netatmo/camera.py
@homeassistant
Copy link
Contributor

Hi @ssenart,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@project-bot project-bot bot added this to Needs review in Dev Oct 20, 2019
@MartinHjelmare MartinHjelmare changed the title Netatmo camera services : Implement enable_motion_detection/disable_motion_detection services and create new services for camera flood light control Add Netatmo camera services Oct 20, 2019
Dev automation moved this from Needs review to Reviewer approved Oct 21, 2019
Copy link
Contributor

@cgtobi cgtobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine with my local setup and LGTM.

@cgtobi
Copy link
Contributor

cgtobi commented Oct 21, 2019

Just an idea. We could also include a service to turn the camera on/off.

"/command/changestatus?status=%s" # "on"|"off"

I tried to get this implemented in pyatmo but it was rejected due to being a possible security issue. This true also for disabling motion detection but IMO it's safe to add since the HA instance should be secured as that might pose a much bigger security threat in itself.

@cgtobi cgtobi closed this Nov 2, 2019
Dev automation moved this from Reviewer approved to Cancelled Nov 2, 2019
@cgtobi cgtobi reopened this Nov 2, 2019
Dev automation moved this from Cancelled to Incoming Nov 2, 2019
@cgtobi cgtobi moved this from Incoming to Reviewer approved in Dev Nov 4, 2019
@cgarwood cgarwood merged commit 9ba3abd into home-assistant:dev Nov 6, 2019
Dev automation moved this from Reviewer approved to Done Nov 6, 2019
@lock lock bot locked and limited conversation to collaborators Nov 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants