Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed STATE_OFF to STATE_STANDBY #28148

Merged
merged 1 commit into from Oct 23, 2019

Conversation

@Villhellm
Copy link
Contributor

Villhellm commented Oct 23, 2019

Breaking Change:

Roku TVs will now report "standby" instead of "off" when they are turned off.

Description:

Roku TVs can be turned on directly to a source by selecting from the source list. When a media_player returns STATE_OFF it loses access to the source list. By returning STATE_STANDBY instead the state is more accurately reflected and the source_list attribute is now accessible when the TV screen is off.

Related issue (if applicable): fixes #25662

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@project-bot project-bot bot added this to Needs review in Dev Oct 23, 2019
@balloob balloob merged commit 062ec8a into home-assistant:dev Oct 23, 2019
12 checks passed
12 checks passed
CI Build #20191023.85 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing b6fd191...84df20f
Details
codecov/project 94.34% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Needs review to Done Oct 23, 2019
@lock lock bot locked and limited conversation to collaborators Oct 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.