Removes unwanted tradfri battery sensor #28181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
integration: tradfri
small-pr
|
Hey there @ggravlingen, mind taking a look at this pull request as its been labeled with a integration ( |
ggravlingen
approved these changes
Oct 24, 2019
|
Filtering like this has worked before so it looks OK |
balloob
approved these changes
Oct 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change:
This removes the battery sensor that was created for the signal repeater.
The sensor would never have a state, and after some inspection, it does not look like that device present any valuable metrics.
Description:
Adds a condition so signal repeaters are not added as battery sensors.
Version bump of the pyradfri lib will happen in #28180 if that is not accepted I will update this PR with it before removing the draft status.
Related issue (if applicable): fixes #27923
Checklist:
tox. Your PR cannot be merged unless tests pass