Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device condition support for device_tracker #28190

Merged
merged 1 commit into from Oct 25, 2019

Conversation

@shmooey
Copy link
Contributor

shmooey commented Oct 25, 2019

Description:

Adds basic device condition support for device_tracker integration - home, not_home.

Related issue (if applicable): fixes #27001

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
Copy link
Member

balloob left a comment

Perfect ! 🎉 🐬

Dev automation moved this from Needs review to Reviewer approved Oct 25, 2019
@balloob balloob merged commit 7ddce1d into home-assistant:dev Oct 25, 2019
11 of 12 checks passed
11 of 12 checks passed
codecov/patch 92.85% of diff hit (target 94.32%)
Details
CI Build #20191025.5 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/project 94.32% (target 90%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Oct 25, 2019
@lock lock bot locked and limited conversation to collaborators Oct 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.