Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty data attribute in sinch service call #28253

Merged
merged 3 commits into from Nov 26, 2019

Conversation

@bendikrb
Copy link
Contributor

bendikrb commented Oct 27, 2019

Description:

Fixes the following error:

  File "/usr/src/homeassistant/homeassistant/components/sinch/notify.py", line 68, in send_message
    if ATTR_SENDER in data:
TypeError: argument of type 'NoneType' is not iterable

caused by calling the service notify.sinch without the data attribute.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
@project-bot project-bot bot added this to Needs review in Dev Oct 27, 2019
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Oct 27, 2019
Dev automation moved this from By Code Owner to Review in progress Nov 2, 2019
Copy link
Member

MartinHjelmare left a comment

Thanks!

Dev automation moved this from Review in progress to Reviewer approved Nov 26, 2019
@MartinHjelmare MartinHjelmare merged commit c538d89 into home-assistant:dev Nov 26, 2019
11 checks passed
11 checks passed
CI #20191126.8 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing cc255da...17e504b
Details
codecov/project 94.48% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Nov 26, 2019
@lock lock bot locked and limited conversation to collaborators Nov 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.