Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve coverage of input_datetime/reproduce_state #28272

Merged

Conversation

@Santobert
Copy link
Member

Santobert commented Oct 27, 2019

Breaking Change:

Nothing breaks

Description:

The coverage didn't work when I submitted the previous pull request. So I did not notice that the coverage was less than 100%. This PR increases the coverage to 100%.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@Santobert Santobert requested a review from home-assistant/core as a code owner Oct 27, 2019
@project-bot project-bot bot added this to Needs review in Dev Oct 27, 2019
@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Oct 27, 2019

Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration (input_datetime) you are listed as a codeowner for? Thanks!

@balloob balloob merged commit 0996b71 into home-assistant:dev Nov 16, 2019
11 checks passed
11 checks passed
CI Build #20191115.33 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.33%)
Details
codecov/project 94.44% (target 90%)
Details
Dev automation moved this from Needs review to Done Nov 16, 2019
pull bot added a commit to KoHcoJlb/home-assistant that referenced this pull request Nov 16, 2019
)

* Improve coverage of input_datetime/reproduce_state

* Improve tests
@lock lock bot locked and limited conversation to collaborators Nov 17, 2019
@Santobert Santobert deleted the Santobert:improve_input_datetime_reproduce_state branch Nov 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.