Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Alexa.ModeController to cover entities, adds open/close utterances! #28309

Merged
merged 8 commits into from Nov 25, 2019

Conversation

@ochlocracy
Copy link
Member

ochlocracy commented Oct 28, 2019

Description:

Adds the elusive open and close utterances that are missing from the Alexa Smart Home API to cover entities!
Finally can open and close covers without instead of using on/off or custom skills. Takes advantage of the custom names for modeResources.

open, opened, raise, raised
close, closed, lower, lowered, shut

Directives for the modeController work best in the following format:

Alexa, set {DEVICE NAME} to {MODE NAME}.

The following short phrases work:

Alexa, set garage door to closed
Alexa, shades to close
Alexa, blinds to open

The following also works, but could never get open to work.

Alexa, shut the living room shades

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • Tests have been added to verify that the new code works.
@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Oct 28, 2019

Hey there @home-assistant/cloud, mind taking a look at this pull request as its been labeled with a integration (alexa) you are listed as a codeowner for? Thanks!

@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Oct 28, 2019
@ochlocracy ochlocracy marked this pull request as ready for review Oct 28, 2019
@ochlocracy ochlocracy changed the title Added Alexa.ModeController to cover entities, adds open/close directives! Added Alexa.ModeController to cover entities, adds open/close utterances! Oct 29, 2019
@MartinHjelmare MartinHjelmare changed the title Added Alexa.ModeController to cover entities, adds open/close utterances! Add Alexa.ModeController to cover entities, adds open/close utterances! Oct 29, 2019
Copy link
Member

balloob left a comment

🎉 🎉 🎉 🎉 Nice !

Dev automation moved this from By Code Owner to Reviewer approved Nov 25, 2019
@balloob balloob merged commit 5ea5db3 into home-assistant:dev Nov 25, 2019
11 checks passed
11 checks passed
CI Build #20191029.38 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 96% of diff hit (target 94.34%)
Details
codecov/project 94.34% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Nov 25, 2019
@lock lock bot locked and limited conversation to collaborators Nov 26, 2019
@ochlocracy ochlocracy deleted the ochlocracy:alexa-cover-mode-controller branch Dec 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.