Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename rest_command request to response, add exc_info for exceptions #28521

Merged
merged 5 commits into from Nov 23, 2019

Conversation

@Misiu
Copy link
Contributor

Misiu commented Nov 4, 2019

Breaking Change: N/A

Description:

  • Renamed request to response, because it was misleading.
  • Imports reordered using isort
  • Added exception info using exc_info=1

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@project-bot project-bot bot added this to Needs review in Dev Nov 4, 2019
@MartinHjelmare MartinHjelmare changed the title rest_command rename request to response, add exc_info for exceptions Rename rest_command request to response, add exc_info for exceptions Nov 4, 2019
Misiu
@Misiu Misiu requested a review from pvizeli Nov 18, 2019
Misiu
Dev automation moved this from Needs review to Reviewer approved Nov 23, 2019
@pvizeli pvizeli merged commit 23737e0 into home-assistant:dev Nov 23, 2019
10 checks passed
10 checks passed
CI #20191119.4 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
codecov/patch Coverage not affected.
Details
codecov/project 94.45% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Nov 23, 2019
AndreBremer added a commit to AndreBremer/home-assistant that referenced this pull request Nov 24, 2019
…ome-assistant#28521)

* rename request to response, isort and black fixes

* Log exception details

* Add status code to success log, reformat log

* new syntax for response

* changed info to debug
@lock lock bot locked and limited conversation to collaborators Nov 24, 2019
@Misiu Misiu deleted the Misiu:rest_command_more_logs branch Nov 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
2 participants
You can’t perform that action at this time.