Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update roomba integration #28560

Merged
merged 2 commits into from Nov 18, 2019
Merged

Update roomba integration #28560

merged 2 commits into from Nov 18, 2019

Conversation

@freekode
Copy link
Contributor

freekode commented Nov 5, 2019

Description:

  • added custom delay for periodic mode

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#11104

Example entry for configuration.yaml (if applicable):

vacuum:
  - platform: roomba
    host: 192.168.0.1
    username: username
    password: password
    name: iRobot
    continuous: false
    delay: 60

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
* added custom delay for periodic mode
@homeassistant

This comment has been minimized.

Copy link
Contributor

homeassistant commented Nov 5, 2019

Hi @freekode,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Nov 5, 2019

Hey there @pschmitt, mind taking a look at this pull request as its been labeled with a integration (roomba) you are listed as a codeowner for? Thanks!

@freekode freekode mentioned this pull request Nov 5, 2019
2 of 2 tasks complete
@homeassistant homeassistant added cla-signed and removed cla-needed labels Nov 5, 2019
@freekode freekode marked this pull request as ready for review Nov 5, 2019
Copy link
Member

MartinHjelmare left a comment

We don't switch pypi package without good reason. Please provide background and history, with timeline, on what steps have been taken to try to update the current package, so we can make a decision.

homeassistant/components/roomba/manifest.json Outdated Show resolved Hide resolved
@MartinHjelmare MartinHjelmare changed the title Updated iRobot integration Update roomba integration Nov 6, 2019
@freekode freekode requested a review from MartinHjelmare Nov 18, 2019
Copy link
Member

MartinHjelmare left a comment

Looks good!

Dev automation moved this from Needs review to Reviewer approved Nov 18, 2019
@MartinHjelmare MartinHjelmare merged commit 1a46294 into home-assistant:dev Nov 18, 2019
11 checks passed
11 checks passed
CI Build #20191118.27 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 11efb2c...6765d09
Details
codecov/project 94.44% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Nov 18, 2019
@freekode freekode deleted the freekode:roomba branch Nov 18, 2019
@lock lock bot locked and limited conversation to collaborators Nov 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.