Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit available heat/cool modes for HomeKit thermostats #28586

Merged
merged 2 commits into from Dec 6, 2019

Conversation

@neffs
Copy link
Contributor

neffs commented Nov 6, 2019

Description:

The Home app now only shows appropriate modes (heat/cool/auto) for the device.
Depending on the climate integration, disabling the auto start might be needed.

This also fixes an issue because HomeKit's Auto was mapped to HA's Heat/Cool, even if not supported by the entity.

Related issue: fixes #28233

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
The Home app only shows appropriate modes (heat/cool/auto) for the device. Depending on the climate integration, disabling the auto start might be needed.
@project-bot project-bot bot added this to Needs review in Dev Nov 6, 2019
Copy link
Member

pvizeli left a comment

Looks good, please update tests

@MartinHjelmare MartinHjelmare changed the title Limit available heat/cool modes for HomeKit thermostats. Limit available heat/cool modes for HomeKit thermostats Nov 7, 2019
@neffs

This comment has been minimized.

Copy link
Contributor Author

neffs commented Dec 5, 2019

Looks good, please update tests
I updated the tests a while ago. anything more to change?

@frenck frenck requested a review from pvizeli Dec 5, 2019
Dev automation moved this from Needs review to Reviewer approved Dec 6, 2019
@pvizeli
pvizeli approved these changes Dec 6, 2019
@pvizeli pvizeli merged commit c5f4872 into home-assistant:dev Dec 6, 2019
11 checks passed
11 checks passed
CI #20191125.16 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch 100% of diff hit (target 94.38%)
Details
codecov/project 94.47% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Dec 6, 2019
@pvizeli pvizeli added this to the 0.103.0 milestone Dec 6, 2019
@lock lock bot locked and limited conversation to collaborators Dec 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
4 participants
You can’t perform that action at this time.