Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable volume controls if openhome volume control disabled #28635

Merged
merged 1 commit into from Nov 26, 2019

Conversation

@bazwilliams
Copy link
Contributor

bazwilliams commented Nov 8, 2019

Description:

Related issue (if applicable): fixes #25531

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

If the code communicates with devices, web services, or third-party tools:

  • [The manifest file][manifest-docs] has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.
@bazwilliams bazwilliams force-pushed the bazwilliams:openhome-volume-fix branch from d0d8cab to 62f8e4d Nov 8, 2019
@MartinHjelmare MartinHjelmare added this to Needs review in Dev Nov 20, 2019
Copy link
Member

balloob left a comment

Nice! 🐬

Dev automation moved this from Needs review to Reviewer approved Nov 26, 2019
@balloob balloob merged commit afaa464 into home-assistant:dev Nov 26, 2019
11 checks passed
11 checks passed
CI Build #20191108.28 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing bd54ff3...62f8e4d
Details
codecov/project 94.42% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Nov 26, 2019
@lock lock bot locked and limited conversation to collaborators Nov 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.