Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UpCloud updates #28646

Merged
merged 6 commits into from Nov 27, 2019
Merged

UpCloud updates #28646

merged 6 commits into from Nov 27, 2019

Conversation

@scop
Copy link
Contributor

scop commented Nov 8, 2019

Description:

Misc UpCloud improvements:

  • upgrade upcloud_api
  • improve entity state right after start and after server start from switch
  • signal handler cleanup

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.
@project-bot project-bot bot added this to Needs review in Dev Nov 8, 2019
@scop scop force-pushed the scop:upcloud-misc branch from 8f384d0 to c297048 Nov 9, 2019
scop added 5 commits Nov 8, 2019
To keep related binary sensor better up to date.
@scop scop force-pushed the scop:upcloud-misc branch from c297048 to 4bc0c40 Nov 16, 2019
@frenck frenck moved this from Needs review to By Code Owner in Dev Nov 20, 2019
Copy link
Member

balloob left a comment

ok to merge when comment addressed

@@ -82,6 +82,7 @@ def upcloud_update(event_time):
dispatcher_send(hass, SIGNAL_UPDATE_UPCLOUD)

# Call the UpCloud API to refresh data
upcloud_update(datetime.now())

This comment has been minimized.

Copy link
@balloob

balloob Nov 25, 2019

Member

Either use None (since you're not using the data) or use utcnow() imported from homeassistant.util.dt to correctly mimic track_time_interval.

Dev automation moved this from By Code Owner to Reviewer approved Nov 25, 2019
@balloob balloob merged commit 738b336 into home-assistant:dev Nov 27, 2019
11 checks passed
11 checks passed
CI #20191127.14 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python36) Tests PyTest Python36 succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing d6e99db...5c91f1f
Details
codecov/project 94.5% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Nov 27, 2019
@scop scop deleted the scop:upcloud-misc branch Nov 27, 2019
@lock lock bot locked and limited conversation to collaborators Nov 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
3 participants
You can’t perform that action at this time.